From fa71d4712d4d5a61c3d56efa1017dba7825ba7bf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Villemot?= <sebastien@dynare.org>
Date: Thu, 16 Jun 2022 15:53:45 +0200
Subject: [PATCH] More explicit message when the Dulmage-Mendelsohn
decomposition returns a non-square block
Closes: #1851
---
matlab/dynare_solve.m | 3 +++
mex/sources/block_trust_region/mexFunction.f08 | 4 +++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/matlab/dynare_solve.m b/matlab/dynare_solve.m
index adc7f02e42..efac88c3a4 100644
--- a/matlab/dynare_solve.m
+++ b/matlab/dynare_solve.m
@@ -229,6 +229,9 @@ elseif ismember(options.solve_algo, [2, 12, 4])
fre = false;
for i=length(r)-1:-1:1
blocklength = r(i+1)-r(i);
+ if s(i+1)-s(i) ~= blocklength
+ error('DYNARE_SOLVE (solve_algo=2|4|12): the Dulmage-Mendelsohn decomposition returned a non-square block. This means that the Jacobian is singular. You may want to try another value for solve_algo.')
+ end
if options.debug
dprintf('DYNARE_SOLVE (solve_algo=2|4|12): solving block %u of size %u.', i, blocklength);
end
diff --git a/mex/sources/block_trust_region/mexFunction.f08 b/mex/sources/block_trust_region/mexFunction.f08
index 1092d42333..512865c6e7 100644
--- a/mex/sources/block_trust_region/mexFunction.f08
+++ b/mex/sources/block_trust_region/mexFunction.f08
@@ -207,7 +207,9 @@ subroutine mexFunction(nlhs, plhs, nrhs, prhs) bind(c, name='mexFunction')
f_indices => blocks(i)%row_indices
x_all => x
if (size(x_indices) /= size(f_indices)) then
- call mexErrMsgTxt("Non-square block")
+ call mexErrMsgTxt("DYNARE_SOLVE (solve_algo=13|14): the Dulmage-Mendelsohn &
+ &decomposition returned a non-square block. This means that the &
+ &Jacobian is singular. You may want to try another value for solve_algo.")
end if
x_block = x(x_indices)
call trust_region_solve(x_block, matlab_fcn, info, tolx, tolf, maxiter, factor)
--
GitLab