dynare issueshttps://git.dynare.org/Dynare/dynare/-/issues2018-09-10T12:35:46Zhttps://git.dynare.org/Dynare/dynare/-/issues/1544dataset_ is a dseries and no longer a structure2018-09-10T12:35:46ZStéphane Adjemianstepan@adjemian.eudataset_ is a dseries and no longer a structure*Created by: thomasbrand*
The last commits about `dseries` (between October 10th and October 14th) modified the type of the `dataset_` output in `results.mat`. It was previously a matlab structure, and now it is a `dseries`. The consequ...*Created by: thomasbrand*
The last commits about `dseries` (between October 10th and October 14th) modified the type of the `dataset_` output in `results.mat`. It was previously a matlab structure, and now it is a `dseries`. The consequence is important (for me) because now I need Dynare to read the `dataset_` output.
Was it on purpose or do you think you will go back to a structure ?
Thank you.Stéphane Adjemianstepan@adjemian.euStéphane Adjemianstepan@adjemian.euhttps://git.dynare.org/Dynare/dynare/-/issues/1578macro-processor: allow for nested variables2018-09-10T12:35:46ZJohannes Pfeifermacro-processor: allow for nested variables1. Related to https://forum.dynare.org/t/total-number-of-periods-given-by-variable/11200/3
We should allow
```
@#define J=10
@#define K=1:@{J}
```
but currently the lexer gives an error when encountering the `@{J}` in the second ...1. Related to https://forum.dynare.org/t/total-number-of-periods-given-by-variable/11200/3
We should allow
```
@#define J=10
@#define K=1:@{J}
```
but currently the lexer gives an error when encountering the `@{J}` in the second line.
2. Related to this, according to the manual, we have at the command line
```-DMACRO_VARIABLE=MACRO_EXPRESSION```
But we do not really macro expressions as
`dynare macro.mod -D=[1,2]`
fails.
3. I tried to get around this by using
```
n_countries=2;
fid=fopen('n_countries_def.txt','w+');
fprintf(fid,'@#for co in 1:%u\n',n_countries)
fclose(fid)
```
to write a text file creating the first statement and then using
```
@#include "n_countries_def.txt"
var C_@{co};
@#endfor
```
But this is also not allowed:
```
ERROR in macro-processor: n_countries_def.txt:1.15: @#for loop not matched by an @#endfor or file does not end with a new line (unexpected end of file)
```
because apparently the macro processor checks for completeness of the macro in each included file instead of the whole created file.
Houtan BastaniHoutan Bastanihttps://git.dynare.org/Dynare/dynare/-/issues/1576Provide steady state file example for Ramsey2020-11-13T14:38:25ZJohannes PfeiferProvide steady state file example for RamseyThe final loop should most probably be
```
NumberOfEndogenousVariables = M_.endo_nbr; % Number of endogenous variables.
ys = zeros(NumberOfEndogenousVariables,1); % Initialization of ys (steady state...The final loop should most probably be
```
NumberOfEndogenousVariables = M_.endo_nbr; % Number of endogenous variables.
ys = zeros(NumberOfEndogenousVariables,1); % Initialization of ys (steady state).
for i = M_.ramsey_eq_nbr+1:NumberOfEndogenousVariables % Loop...
varname = deblank(M_.endo_names(i-M_.ramsey_eq_nbr,:)); % Get the name of endogenous variable i.
eval(['ys(' int2str(i) ') = ' varname ';']); % Get the steady state value of this variable.
end % End of the loop.
```Johannes PfeiferJohannes Pfeiferhttps://git.dynare.org/Dynare/dynare/-/issues/1570Fix steady_state_model-block check with instruments2018-09-10T12:35:47ZJohannes PfeiferFix steady_state_model-block check with instrumentsI have a model with
```
steady_state_model;
Q=1/R;
end;
planner_objective Welfare;
ramsey_model(instruments=(R),planner_discount=betta);
```
This is a proper conditional steady state file, where the instrument is taken as given...I have a model with
```
steady_state_model;
Q=1/R;
end;
planner_objective Welfare;
ramsey_model(instruments=(R),planner_discount=betta);
```
This is a proper conditional steady state file, where the instrument is taken as given. But it results in
```
ERROR: in the 'steady_state_model' block, variable 'R' is undefined in the declaration of variable 'Q'
```
because the preprocessor check does not account for the conditionality.
https://git.dynare.org/Dynare/dynare/-/issues/1558Allow diffuse_filter as option for dynare_sensitivity2018-09-10T12:35:47ZJohannes PfeiferAllow diffuse_filter as option for dynare_sensitivityhttps://git.dynare.org/Dynare/dynare/-/issues/1555Allow mod files to be read from stdin2019-11-21T08:36:43ZHoutan BastaniAllow mod files to be read from stdinAllow a .mod file to be piped into the preprocessor.
For the GUIAllow a .mod file to be piped into the preprocessor.
For the GUIHoutan BastaniHoutan Bastanihttps://git.dynare.org/Dynare/dynare/-/issues/1550Support in-line comments in macroprocessor2019-11-21T08:36:42ZTom HoldenSupport in-line comments in macroprocessorThis page: http://www.dynare.org/manual/Macro_002dprocessing-language.html#Macro_002dprocessing-language
contains an example in which a pre-processor definition is followed by a // comment. This generates an error in reality. Try e.g.
...This page: http://www.dynare.org/manual/Macro_002dprocessing-language.html#Macro_002dprocessing-language
contains an example in which a pre-processor definition is followed by a // comment. This generates an error in reality. Try e.g.
```
@#define x = 5 // Integer
parameters a;
a = 1;
```
This is something that should be supported though. The simplest solution would be for the pre-processor to remove all // comments in the generated -macroexp.mod.
Houtan BastaniHoutan Bastanihttps://git.dynare.org/Dynare/dynare/-/issues/1551Pre-processor should remove empty lines2019-06-19T15:37:41ZTom HoldenPre-processor should remove empty linesWhen using complicated logic in the pre-processor language, one can often end up with files full of thousands of empty lines. This is both because empty lines are necessary to make pre-processor code readable, and because of the need to ...When using complicated logic in the pre-processor language, one can often end up with files full of thousands of empty lines. This is both because empty lines are necessary to make pre-processor code readable, and because of the need to have empty lines at the end of .mod files that finish with e.g. an @#endfor .
It would be helpful if the pre-processor removed empty lines in the generated -macroexp.mod.https://git.dynare.org/Dynare/dynare/-/issues/1546Pre-processor division by zero error does not include line numbers (and inclu...2019-06-19T15:37:41ZTom HoldenPre-processor division by zero error does not include line numbers (and includes typo)Currently, a division by zero in the pre-processor triggers the following error:
ERROR: Division by zero!
...division by zero error encountred when reading model from .mod file
Note the typo in the spelling of "encountered...Currently, a division by zero in the pre-processor triggers the following error:
ERROR: Division by zero!
...division by zero error encountred when reading model from .mod file
Note the typo in the spelling of "encountered".
It would be good if this was consistent with the formatting of other pre-processor errors, including file names and line numbers, e.g.:
ERROR in macro-processor: CreateIndicesArray.mod:8.37-69: Division by zero encounteredHoutan BastaniHoutan Bastanihttps://git.dynare.org/Dynare/dynare/-/issues/1548Pre-processor bug: plot_shock_decomposition2019-06-19T15:37:41ZMarco RattoPre-processor bug: plot_shock_decompositionThe type option is not properly handled, since it always provides qoq field
`options_.plot_shock_decomp.type = 'qoq'; `
whatever this choice `qoq | yoy | aoa`
The type option is not properly handled, since it always provides qoq field
`options_.plot_shock_decomp.type = 'qoq'; `
whatever this choice `qoq | yoy | aoa`
Johannes PfeiferJohannes Pfeiferhttps://git.dynare.org/Dynare/dynare/-/issues/1547allow length operator in macroprocessor to return the length of strings2019-06-19T15:37:41ZTom Holdenallow length operator in macroprocessor to return the length of stringsAt present, the length operator applied to a string always returns 1.
It would be good if it returned the length of the string.
Try e.g.:
```
@#define Numbers = [ "1", "2", "3", "4", "5", "6" ]
@#define TestString = "Hello"
@...At present, the length operator applied to a string always returns 1.
It would be good if it returned the length of the string.
Try e.g.:
```
@#define Numbers = [ "1", "2", "3", "4", "5", "6" ]
@#define TestString = "Hello"
@#echo Numbers[ length( TestString ) ]
parameters a;
a = 1;
```
Incidentally, it would be good if there was a number to string function in the pre-processor!Sébastien VillemotSébastien Villemothttps://git.dynare.org/Dynare/dynare/-/issues/1545Test matlab version in isfile routine2019-06-19T15:37:41ZStéphane Adjemianstepan@adjemian.euTest matlab version in isfile routineSee [here](https://forum.dynare.org/t/getting-error-in-dynare-4-5-2/10896).See [here](https://forum.dynare.org/t/getting-error-in-dynare-4-5-2/10896).https://git.dynare.org/Dynare/dynare/-/issues/1543Rename distributed PDFs in doc folder2019-02-21T16:03:54ZJohannes PfeiferRename distributed PDFs in doc folderThe names should be more expressive. For example, `dynare.pdf` should be `Adjemian_et_al_2011_Dynare_Manual_4.pdf` or similar.The names should be more expressive. For example, `dynare.pdf` should be `Adjemian_et_al_2011_Dynare_Manual_4.pdf` or similar.Sébastien VillemotSébastien Villemothttps://git.dynare.org/Dynare/dynare/-/issues/1541Make isfile compatible with Octave/older Matlab2019-06-19T15:37:41ZJohannes PfeiferMake isfile compatible with Octave/older MatlabIn `missing\isfile` we rely on `isstring`, which was introduced in `R2016b` and is not available on OctaveIn `missing\isfile` we rely on `isstring`, which was introduced in `R2016b` and is not available on OctaveStéphane Adjemianstepan@adjemian.euStéphane Adjemianstepan@adjemian.euhttps://git.dynare.org/Dynare/dynare/-/issues/1539create a reporting tutorial website2020-05-07T17:46:42ZHoutan Bastanicreate a reporting tutorial websiteGoing from simple examples to more complex examples to make the code more approachable
Going from simple examples to more complex examples to make the code more approachable
https://git.dynare.org/Dynare/dynare/-/issues/1534Add documentation for SMM/GMM/IRF options2021-01-21T15:54:44ZJohannes PfeiferAdd documentation for SMM/GMM/IRF optionsRelevant commits are https://github.com/DynareTeam/dynare/commit/254a73a4065a4b476296391dd22672637f82fc72 and https://github.com/DynareTeam/dynare/commit/d52f13114d10fbe5fd4d263d5d0b9d7cfda787f6Relevant commits are https://github.com/DynareTeam/dynare/commit/254a73a4065a4b476296391dd22672637f82fc72 and https://github.com/DynareTeam/dynare/commit/d52f13114d10fbe5fd4d263d5d0b9d7cfda787f6Johannes PfeiferJohannes Pfeiferhttps://git.dynare.org/Dynare/dynare/-/issues/1527Add Occbin2019-06-19T15:37:42ZJohannes PfeiferAdd Occbinhttps://git.dynare.org/Dynare/dynare/-/issues/1523rename isfile.m as there is a function called isfile in Matlab R2017b2019-06-19T15:37:42ZHoutan Bastanirename isfile.m as there is a function called isfile in Matlab R2017bStéphane Adjemianstepan@adjemian.euStéphane Adjemianstepan@adjemian.euhttps://git.dynare.org/Dynare/dynare/-/issues/1524Enable method argument of gamrnd.m2018-12-15T16:11:55ZJohannes PfeiferEnable method argument of gamrnd.mCurrently, we provide an error.Currently, we provide an error.Stéphane Adjemianstepan@adjemian.euStéphane Adjemianstepan@adjemian.euhttps://git.dynare.org/Dynare/dynare/-/issues/1503Do we really need to have specific dynamic routines for deterministic and sto...2020-12-08T13:50:02ZStéphane Adjemianstepan@adjemian.euDo we really need to have specific dynamic routines for deterministic and stochastic models?See discussion in #1501.See discussion in #1501.