diff --git a/src/DynamicModel.cc b/src/DynamicModel.cc index e165fe2064fb62a647d4e535e95978417311ca99..29e8bd3fdf5247a0d21ff8c52218cc1b0e28c902 100644 --- a/src/DynamicModel.cc +++ b/src/DynamicModel.cc @@ -2778,7 +2778,7 @@ DynamicModel::writeBlockDriverOutput(ostream &output, const string &basename, } void -DynamicModel::writeDriverOutput(ostream &output, const string &basename, bool block_decomposition, bool use_dll, bool occbin, bool estimation_present, bool compute_xrefs) const +DynamicModel::writeDriverOutput(ostream &output, const string &basename, bool block_decomposition, bool estimation_present, bool compute_xrefs) const { /* Writing initialisation for M_.lead_lag_incidence matrix M_.lead_lag_incidence is a matrix with as many columns as there are @@ -3682,7 +3682,7 @@ DynamicModel::analyzePacEquationStructure(const string &name, map<string, string exit(EXIT_FAILURE); } auto [optim_share_index, optim_part, non_optim_part, additive_part] - = arg2->getPacOptimizingShareAndExprNodes(lhs_symb_id, lhs_orig_symb_id); + = arg2->getPacOptimizingShareAndExprNodes(lhs_orig_symb_id); pair<int, vector<tuple<int, bool, int>>> ec_params_and_vars; vector<tuple<optional<int>, optional<int>, int>> ar_params_and_vars; @@ -3756,7 +3756,7 @@ DynamicModel::getPacTargetSymbId(const string &pac_model_name) const if (!barg2) throw PacTargetNotIdentifiedException{pac_model_name, "RHS must be a binary operator"}; auto [optim_share_index, optim_part, non_optim_part, additive_part] - = barg2->getPacOptimizingShareAndExprNodes(lhs_symb_id, undiff_lhs_symb_id); + = barg2->getPacOptimizingShareAndExprNodes(undiff_lhs_symb_id); /* If there is an optimization part, restrict the search to that part, since it contains the MCE . */ expr_t mce = optim_part ? optim_part : equation->arg2; @@ -5874,7 +5874,7 @@ DynamicModel::addOccbinEquation(expr_t eq, optional<int> lineno, const map<strin } bool -DynamicModel::isChecksumMatching(const string &basename, bool block) const +DynamicModel::isChecksumMatching(const string &basename) const { stringstream buffer; diff --git a/src/DynamicModel.hh b/src/DynamicModel.hh index c6ec1a40304680293ae25b33e2c77678ecc4143d..a9a31c47631ab54dfa24ad418154ebbdbc5d4017 100644 --- a/src/DynamicModel.hh +++ b/src/DynamicModel.hh @@ -330,7 +330,7 @@ public: void computingPass(bool jacobianExo, int derivsOrder, int paramsDerivsOrder, const eval_context_t &eval_context, bool no_tmp_terms, bool block, bool use_dll); //! Writes information about the dynamic model to the driver file - void writeDriverOutput(ostream &output, const string &basename, bool block, bool use_dll, bool occbin, bool estimation_present, bool compute_xrefs) const; + void writeDriverOutput(ostream &output, const string &basename, bool block, bool estimation_present, bool compute_xrefs) const; //! Write JSON AST void writeJsonAST(ostream &output) const; @@ -638,7 +638,7 @@ public: //! Returns true if a parameter was used in the model block with a lead or lag bool ParamUsedWithLeadLag() const; - bool isChecksumMatching(const string &basename, bool block) const; + bool isChecksumMatching(const string &basename) const; //! Simplify model equations: if a variable is equal to a constant, replace that variable elsewhere in the model /*! Equations with MCP tags are excluded, see dynare#1697 */ diff --git a/src/ExprNode.cc b/src/ExprNode.cc index 7255368606ac8fcad1349bf13c624e33d74cad3f..33ce67217d714d6fb904d78746eae02dcf6df46b 100644 --- a/src/ExprNode.cc +++ b/src/ExprNode.cc @@ -5487,7 +5487,7 @@ BinaryOpNode::getPacNonOptimizingPart(int optim_share_symb_id) const } pair<optional<int>, expr_t> -BinaryOpNode::getPacOptimizingShareAndExprNodesHelper(int lhs_symb_id, int lhs_orig_symb_id) const +BinaryOpNode::getPacOptimizingShareAndExprNodesHelper(int lhs_orig_symb_id) const { optional<int> optim_param_symb_id; expr_t optim_part = nullptr; @@ -5514,7 +5514,7 @@ BinaryOpNode::getPacOptimizingShareAndExprNodesHelper(int lhs_symb_id, int lhs_o } tuple<optional<int>, expr_t, expr_t, expr_t> -BinaryOpNode::getPacOptimizingShareAndExprNodes(int lhs_symb_id, int lhs_orig_symb_id) const +BinaryOpNode::getPacOptimizingShareAndExprNodes(int lhs_orig_symb_id) const { vector<pair<expr_t, int>> terms; decomposeAdditiveTerms(terms, 1); @@ -5532,7 +5532,7 @@ BinaryOpNode::getPacOptimizingShareAndExprNodes(int lhs_symb_id, int lhs_orig_sy if (auto bopn = dynamic_cast<BinaryOpNode *>(it->first); bopn) { tie(optim_share, optim_part) - = bopn->getPacOptimizingShareAndExprNodesHelper(lhs_symb_id, lhs_orig_symb_id); + = bopn->getPacOptimizingShareAndExprNodesHelper(lhs_orig_symb_id); if (optim_share && optim_part) { terms.erase(it); diff --git a/src/ExprNode.hh b/src/ExprNode.hh index 774a414d39e0e2531f343c35ee7eca1bdf4ec144..5f8a1b09381e94c76b7e342fc712bee9e774c494 100644 --- a/src/ExprNode.hh +++ b/src/ExprNode.hh @@ -1154,8 +1154,8 @@ public: //! Finds the share of optimizing agents in the PAC equation, //! the expr node associated with it, //! and the expr node associated with the non-optimizing part - tuple<optional<int>, expr_t, expr_t, expr_t> getPacOptimizingShareAndExprNodes(int lhs_symb_id, int lhs_orig_symb_id) const; - pair<optional<int>, expr_t> getPacOptimizingShareAndExprNodesHelper(int lhs_symb_id, int lhs_orig_symb_id) const; + tuple<optional<int>, expr_t, expr_t, expr_t> getPacOptimizingShareAndExprNodes(int lhs_orig_symb_id) const; + pair<optional<int>, expr_t> getPacOptimizingShareAndExprNodesHelper(int lhs_orig_symb_id) const; expr_t getPacNonOptimizingPart(int optim_share_symb_id) const; bool isParamTimesEndogExpr() const override; //! Substitute auxiliary variables by their expression in static model diff --git a/src/ModFile.cc b/src/ModFile.cc index 6489e41d112c06697a42c1eef4143b08e36ce28d..9d8cf8cdcfc2a3038fe96756fa39aa83faeb46d0 100644 --- a/src/ModFile.cc +++ b/src/ModFile.cc @@ -114,9 +114,9 @@ ModFile::checkPass(bool nostrict, bool stochastic) steady_state_model.checkPass(mod_file_struct, warnings); // Check epilogue block - epilogue.checkPass(mod_file_struct, warnings); + epilogue.checkPass(mod_file_struct); - pac_model_table.checkPass(mod_file_struct, warnings); + pac_model_table.checkPass(mod_file_struct); if (mod_file_struct.write_latex_steady_state_model_present && !mod_file_struct.steady_state_model_present) @@ -785,7 +785,7 @@ ModFile::writeMOutput(const string &basename, bool clear_all, bool clear_global, const filesystem::path &matlabroot, const filesystem::path &dynareroot, bool onlymodel, bool gui, bool notime) const { - bool hasModelChanged = !dynamic_model.isChecksumMatching(basename, block) || !check_model_changes; + bool hasModelChanged = !dynamic_model.isChecksumMatching(basename) || !check_model_changes; if (hasModelChanged) { // Erase possible remnants of previous runs @@ -893,8 +893,8 @@ ModFile::writeMOutput(const string &basename, bool clear_all, bool clear_global, var_model_table.writeOutput(basename, mOutputFile); trend_component_model_table.writeOutput(basename, mOutputFile); - var_expectation_model_table.writeOutput(basename, mOutputFile); - pac_model_table.writeOutput(basename, mOutputFile); + var_expectation_model_table.writeOutput(mOutputFile); + pac_model_table.writeOutput(mOutputFile); // Initialize M_.Sigma_e, M_.Correlation_matrix, M_.H, and M_.Correlation_matrix_ME mOutputFile << "M_.Sigma_e = zeros(" << symbol_table.exo_nbr() << ", " @@ -968,7 +968,7 @@ ModFile::writeMOutput(const string &basename, bool clear_all, bool clear_global, if (dynamic_model.equation_number() > 0) { - dynamic_model.writeDriverOutput(mOutputFile, basename, block, use_dll, mod_file_struct.occbin_constraints_present, mod_file_struct.estimation_present, compute_xrefs); + dynamic_model.writeDriverOutput(mOutputFile, basename, block, mod_file_struct.estimation_present, compute_xrefs); if (!no_static) static_model.writeDriverOutput(mOutputFile, block); } @@ -1087,7 +1087,7 @@ ModFile::writeMOutput(const string &basename, bool clear_all, bool clear_global, } // Create steady state file - steady_state_model.writeSteadyStateFile(basename, mod_file_struct.ramsey_model_present, false); + steady_state_model.writeSteadyStateFile(basename, false); // Create epilogue file epilogue.writeEpilogueFile(basename); @@ -1111,7 +1111,7 @@ ModFile::writeJuliaOutput(const string &basename) const dynamic_model.writeDynamicFile(basename, block, use_dll, "", {}, {}, true); dynamic_model.writeParamsDerivativesFile(basename, true); } - steady_state_model.writeSteadyStateFile(basename, mod_file_struct.ramsey_model_present, true); + steady_state_model.writeSteadyStateFile(basename, true); } void diff --git a/src/ModelEquationBlock.cc b/src/ModelEquationBlock.cc index 002a4af0b6e42d71ece6d3520838b469f4bc7444..afe3b36f56411e8fc0bdb24bdb3f8a88add4ab33 100644 --- a/src/ModelEquationBlock.cc +++ b/src/ModelEquationBlock.cc @@ -177,7 +177,7 @@ SteadyStateModel::writeLatexSteadyStateFile(const string &basename) const } void -SteadyStateModel::writeSteadyStateFile(const string &basename, bool ramsey_model, bool julia) const +SteadyStateModel::writeSteadyStateFile(const string &basename, bool julia) const { if (def_table.size() == 0) return; @@ -307,7 +307,7 @@ Epilogue::addDefinition(int symb_id, expr_t expr) } void -Epilogue::checkPass(ModFileStructure &mod_file_struct, WarningConsolidation &warnings) const +Epilogue::checkPass(ModFileStructure &mod_file_struct) const { if (dynamic_def_table.size() == 0) { diff --git a/src/ModelEquationBlock.hh b/src/ModelEquationBlock.hh index 0b11712c38b139ba91e7f301b73addbdb244973f..d2382cdb715ae985007042c7146149019eb8b47c 100644 --- a/src/ModelEquationBlock.hh +++ b/src/ModelEquationBlock.hh @@ -54,10 +54,7 @@ public: */ void checkPass(ModFileStructure &mod_file_struct, WarningConsolidation &warnings) const; //! Write the steady state file - /*! - \param[in] ramsey_model Is there a Ramsey model in the MOD file? If yes, then use the "ys" in argument of the steady state file as initial values - */ - void writeSteadyStateFile(const string &basename, bool ramsey_model, bool julia) const; + void writeSteadyStateFile(const string &basename, bool julia) const; //! Writes LaTeX file with the equations of the dynamic model (for the steady state model) void writeLatexSteadyStateFile(const string &basename) const; //! Writes JSON output @@ -83,7 +80,7 @@ public: void addDefinition(int symb_id, expr_t expr); //! Checks that no variable is declared twice, and that “with_epilogue” is not misused - void checkPass(ModFileStructure &mod_file_struct, WarningConsolidation &warnings) const; + void checkPass(ModFileStructure &mod_file_struct) const; //! Creates static epilogue equations void toStatic(); diff --git a/src/SubModel.cc b/src/SubModel.cc index 1974e022559c5ac39272c4cf435dae33bc6c0bc9..4c1ab5baa0fb96ccc9f61b314f030c9213212a76 100644 --- a/src/SubModel.cc +++ b/src/SubModel.cc @@ -771,7 +771,7 @@ VarExpectationModelTable::empty() const } void -VarExpectationModelTable::writeOutput(const string &basename, ostream &output) const +VarExpectationModelTable::writeOutput(ostream &output) const { for (const auto &name : names) { @@ -986,7 +986,7 @@ PacModelTable::empty() const } void -PacModelTable::checkPass(ModFileStructure &mod_file_struct, WarningConsolidation &warnings) +PacModelTable::checkPass(ModFileStructure &mod_file_struct) { for (auto &[name, gv] : growth) if (gv) @@ -1364,7 +1364,7 @@ PacModelTable::transformPass(const lag_equivalence_table_t &unary_ops_nodes, } void -PacModelTable::writeOutput(const string &basename, ostream &output) const +PacModelTable::writeOutput(ostream &output) const { // Helper to print the “growth_info” structure (linear decomposition of growth) auto growth_info_helper = [&](const string &fieldname, const growth_info_t &gi) diff --git a/src/SubModel.hh b/src/SubModel.hh index 8020539510375a0edf84163b55a1c8ceacfc5ad8..583720c723d798c8b98e1c79f2607cc5dffa8a87 100644 --- a/src/SubModel.hh +++ b/src/SubModel.hh @@ -218,7 +218,7 @@ public: void transformPass(ExprNode::subst_table_t &diff_subst_table, DynamicModel &dynamic_model, const VarModelTable &var_model_table, const TrendComponentModelTable &trend_component_model_table); - void writeOutput(const string &basename, ostream &output) const; + void writeOutput(ostream &output) const; void writeJsonOutput(ostream &output) const; }; @@ -307,7 +307,7 @@ public: void addPacModel(string name_arg, string aux_model_name_arg, string discount_arg, expr_t growth_arg, string auxname_arg, PacTargetKind kind_arg); bool isExistingPacModelName(const string &name_arg) const; bool empty() const; - void checkPass(ModFileStructure &mod_file_struct, WarningConsolidation &warnings); + void checkPass(ModFileStructure &mod_file_struct); // Called by DynamicModel::substituteUnaryOps() void substituteUnaryOpsInGrowth(const lag_equivalence_table_t &nodes, ExprNode::subst_table_t &subst_table, vector<BinaryOpNode *> &neweqs); void findDiffNodesInGrowth(lag_equivalence_table_t &diff_nodes) const; @@ -320,7 +320,7 @@ public: ExprNode::subst_table_t &diff_subst_table, DynamicModel &dynamic_model, const VarModelTable &var_model_table, const TrendComponentModelTable &trend_component_model_table); - void writeOutput(const string &basename, ostream &output) const; + void writeOutput(ostream &output) const; void writeJsonOutput(ostream &output) const; void setTargetExpr(const string &name_arg, expr_t target); void setTargetAuxnameNonstationary(const string &name_arg, string auxname);