From 743ccf77730265df17b12f9ec8cb0114e86d53ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Villemot?= <sebastien@dynare.org>
Date: Fri, 19 Jul 2024 13:52:30 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Occbin:=20fix=20loop=20over=20al?=
 =?UTF-8?q?l=20regimes=20combination?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

std::fill takes a range that is open on the right bound (i.e. [first, last) and
not [first, last]).
---
 src/DynamicModel.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/DynamicModel.cc b/src/DynamicModel.cc
index 29fa86d7..32365f15 100644
--- a/src/DynamicModel.cc
+++ b/src/DynamicModel.cc
@@ -4397,8 +4397,7 @@ DynamicModel::OccbinRegimeTracker::checkAllRegimesPresent() const
       if (it == r.end())
         break;
       *it = true;
-      if (it != r.begin())
-        fill(r.begin(), prev(it), false);
+      fill(r.begin(), it, false);
     }
   while (true);
 }
-- 
GitLab