From c04960d583694848a7a466989a8ba68fed9c5722 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Villemot?= <sebastien@dynare.org>
Date: Mon, 3 Apr 2023 18:32:32 +0200
Subject: [PATCH] Bytecode: minor improvements of interfacing with UMFPACK

---
 mex/sources/bytecode/SparseMatrix.cc | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/mex/sources/bytecode/SparseMatrix.cc b/mex/sources/bytecode/SparseMatrix.cc
index 204861960c..303124ccc9 100644
--- a/mex/sources/bytecode/SparseMatrix.cc
+++ b/mex/sources/bytecode/SparseMatrix.cc
@@ -2360,14 +2360,13 @@ dynSparseMatrix::Solve_LU_UMFPack(SuiteSparse_long *Ap, SuiteSparse_long *Ai, do
   double Control[UMFPACK_CONTROL], Info[UMFPACK_INFO], res[n];
 
   umfpack_dl_defaults(Control);
-  Control[UMFPACK_PRL] = 5;
   SuiteSparse_long status = 0;
   if (iter == 0)
     {
       if (Symbolic)
         umfpack_dl_free_symbolic(&Symbolic);
       status = umfpack_dl_symbolic(n, n, Ap, Ai, Ax, &Symbolic, Control, Info);
-      if (status < 0)
+      if (status != UMFPACK_OK)
         {
           umfpack_dl_report_info(Control, Info);
           umfpack_dl_report_status(Control, status);
@@ -2377,7 +2376,7 @@ dynSparseMatrix::Solve_LU_UMFPack(SuiteSparse_long *Ap, SuiteSparse_long *Ai, do
   if (Numeric)
     umfpack_dl_free_numeric(&Numeric);
   status = umfpack_dl_numeric(Ap, Ai, Ax, Symbolic, &Numeric, Control, Info);
-  if (status < 0)
+  if (status != UMFPACK_OK)
     {
       umfpack_dl_report_info(Control, Info);
       umfpack_dl_report_status(Control, status);
@@ -2469,14 +2468,13 @@ dynSparseMatrix::Solve_LU_UMFPack(SuiteSparse_long *Ap, SuiteSparse_long *Ai, do
   double Control[UMFPACK_CONTROL], Info[UMFPACK_INFO], res[n];
 
   umfpack_dl_defaults(Control);
-  Control[UMFPACK_PRL] = 5;
   SuiteSparse_long status = 0;
   if (iter == 0)
     {
       if (Symbolic)
         umfpack_dl_free_symbolic(&Symbolic);
       status = umfpack_dl_symbolic(n, n, Ap, Ai, Ax, &Symbolic, Control, Info);
-      if (status < 0)
+      if (status != UMFPACK_OK)
         {
           umfpack_dl_report_info(Control, Info);
           umfpack_dl_report_status(Control, status);
@@ -2486,7 +2484,7 @@ dynSparseMatrix::Solve_LU_UMFPack(SuiteSparse_long *Ap, SuiteSparse_long *Ai, do
   if (Numeric)
     umfpack_dl_free_numeric(&Numeric);
   status = umfpack_dl_numeric(Ap, Ai, Ax, Symbolic, &Numeric, Control, Info);
-  if (status < 0)
+  if (status != UMFPACK_OK)
     {
       umfpack_dl_report_info(Control, Info);
       umfpack_dl_report_status(Control, status);
-- 
GitLab