Skip to content
Snippets Groups Projects
Verified Commit c190ec3a authored by Houtan Bastani's avatar Houtan Bastani
Browse files

mex: support compilation on mac with clang + openmp

parent 53ae5493
No related merge requests found
Pipeline #1557 passed
Stage: build
Stage: test
Hide whitespace changes
Inline Side-by-side
  • Sébastien Villemot @sebastien ·
    Owner

    Does this work? Do you want to have this merged?

    If the answer to both questions is yes, then I would suggest rewriting this patch by introducing two variables (something like OPENMP_CXXFLAGS and OPENMP_LDADD) that would be set by the configure script and that would contain whatever is relevant for the platform (i.e. respectively -fopenmp and nothing on GNU/Linux and Windows, and whatever is needed on macOS). Hence the check for the MACOS conditional in all *.am files could be removed.

  • Houtan Bastani @houtanb ·
    Author Contributor

    I just pushed that in case it would be useful in the future. It compiles and runs but I don't like the solution setting KMP_DUPLICATE_LIB_OK to true. So, for now, we should just keep this in a branch.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment