Skip to content
Snippets Groups Projects
Verified Commit e5102eee authored by Stéphane Adjemian's avatar Stéphane Adjemian
Browse files

Bug fix for mode_compute=6.

We did not keep track of the first and second order moment when calling gmhmaxlik_core.
parent 982ec2e6
No related branches found
No related tags found
No related merge requests found
Loading
  • Stéphane Adjemian @stepan-a

    mentioned in commit dfb6843f

    ·

    mentioned in commit dfb6843f

    Toggle commit list
  • Johannes Pfeifer @JohannesPfeifer ·
    Developer

    @stepan-a I would have preferred to discuss this change before pushing. It implies a big change in terms of backward compatibility. Instead of computing the covariance from scratch based on the existing sample draws, we now update gradually based on an initialization.

  • Author Owner

    Ah... My understanding is that it fixes the bug you spotted. As far as I am concerned, I always had in mind that the initial variance should have a (small) effect and that repeated calls to gmhmaxlik_core should keep track of the current values for the mean and covariance matrix. It's true that the patch changes the results. I'll revert the cherry-pick in 5.x.

  • Johannes Pfeifer @JohannesPfeifer

    mentioned in merge request !2075 (merged)

    ·

    mentioned in merge request !2075 (merged)

    Toggle commit list
  • Johannes Pfeifer @JohannesPfeifer

    mentioned in merge request !2068 (closed)

    ·

    mentioned in merge request !2068 (closed)

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment