Skip to content
Snippets Groups Projects
Verified Commit 5b80a4db authored by Sébastien Villemot's avatar Sébastien Villemot
Browse files

Unary ops substitution: bugfix, actually restrict the substitution to the chosen equations

By default, the preprocessor is supposed to only do the “unary ops”
transformation in the equations of VAR/PAC/trend component models.

However, the implementation was slightly different so far. It would detect
candidates to this transformation in the chosen equations, but it would then
perform the substitution in *all* equations.

This could lead for crashes, for example if the chosen equation contains
log(X(-1)), but another (non-chosen) equation has log(X(-2)). Then this latter
expression, even though it belongs to the same lag-equivalence class, is not
properly handled, causing a segfault.

Also do a few related cosmetic changes.
parent 59bda04d
No related branches found
No related tags found
No related merge requests found
Pipeline #3957 passed
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment