Skip to content
Snippets Groups Projects

ModelTree.cc: Provide output in case of failure

Closed Johannes Pfeifer requested to merge JohannesPfeifer/preprocessor:debug_compilation into master
1 unresolved thread

Related to #116

Edited by Johannes Pfeifer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1998 1998 {
1999 1999 lk.unlock();
2000 2000 int r {system(cmd.c_str())};
2001 if (r)
2002 cout << cmd.c_str() << endl;
  • More generally, what are you trying to do exactly? This commit will print the GCC command line whenever a compilation fails. First, this is going to be very esoteric to the user, so this looks more like something that should be output only in some debug mode, or at least with some additional context information. Second, it does not convey the error message itself, and I’m not sure how the latter can be retrieved.

  • The plan is to provide any error message on what went wrong during compilation (as opposed to just stating the obvious that it failed).

  • Thanks for clarifying. Then as said above, your proposed changes don’t achieve that goal.

  • I remembered something different, but with the current multithreading it not even gives the correct command line to run.

  • Indeed the command line is currently not printed, and your MR would print it. But my point is that it’s not the error message itself.

  • Please register or sign in to reply
    Loading