Add missing smoother options to shock_decomposition

added bug label

merged

mentioned in commit ca702480

@JohannesPfeifer Do you plan to update the reference manual?

@sebastien Yes, I will do so.

It's in dynare!1724 (merged)

Do you consider that this should go on the 4.6 branch?

Technically this is not a bug. However, it seems reasonable to be able to tweak the smoother when doing the shock decomposition, and there is a priori no risk of regression.

From a design perspective, I consider this to be a bug. shock_decomposition should work without other commands being present, but this is not the case. For example, if you require setting diffuse_filter because your model has a unit root, there is no way to set it. You would need to have either calib_smoother or estimation present. Having shock_decomposition only work in conjunction with other commands strikes me as a bug. Similarly, you can not select the range of an Excel sheet in the data file you can specify.

So I think it is necessary to port it. And you are right, the risk of regression should be non-existent.