Add interface for forecast_shock_decomposition.
Merge request reports
Activity
I think this is almost ready for merge. Two things still need to be adjusted:
-
I don’t like the fact that the
type
option can take integer values (if I understand correctly, 1 is for unconditional forecast, and 2 for the conditional forecast), because this is not self-explicit for the user (we made that same mistake for therealtime
option ofrealtime_shock_decomposition
, but we should avoid doing that again). I rather suggest to use explicit keywords, more preciselytype = unconditional
andtype = conditional
. I guesstype = unconditional
should be the default if unspecified. -
Please reference the Gitlab issue in the commit message. You need to mention the string
Dynare/dynare#1657
in the message.
-
mentioned in merge request dynare!1671 (closed)
added 1 commit
- 927be12f - Add interface for forecast_shock_decomposition dynare#1657.
added 1 commit
- 8bfcefe7 - Add interface for forecast_shock_decomposition. dynare#1657
mentioned in commit 3ae92499
In my last commit, the tokens were added. I just checked the merge and they are there.
Edited by Dóra Kocsis