StaticModel: remove transformation of complex residuals
Closes #117 (closed)
Merge request reports
Activity
assigned to @sebastien
I don’t understand why there are two different formulas used here, without any clear pattern. If
is a complex number,is used in some cases, andis used in others. What’s the rationale?Also, the commit message is misleading. The transformation of complex residuals is not removed, just modified.
- I thought in
g1_v
thesign(x)*2*x
was for the derivative ofx^2
. If we only care about non-complex residuals, having a complex Jacobian should not be problematic. We already handle this case. - Given all these complications and edge cases, I suggest having the solver potentially output complex residuals and then handle the complications at the Matlab level. We already do so at various points of the code.
- I thought in
added 1 commit
- bc5086e3 - StaticModel: remove transformation of complex residuals
added 5 commits
-
bc5086e3...c8cd182e - 4 commits from branch
Dynare:master
- 2aecc32e - StaticModel: remove transformation of complex residuals
-
bc5086e3...c8cd182e - 4 commits from branch
added 4 commits
-
2aecc32e...140c91e9 - 3 commits from branch
Dynare:master
- bfecd354 - StaticModel: remove transformation of complex residuals
-
2aecc32e...140c91e9 - 3 commits from branch
Can you please squash the two commits?
Also, I have the impression that you removed too much in the Julia output. By the way, @MichelJuillard, is this modification also supposed to be applied to Julia?
added 1 commit
- 812cd86e - StaticModel: remove transformation of complex residuals
added 1 commit
- 6e8a78e6 - StaticModel: remove transformation of complex residuals for Julia as well
I appended a Julia commit following @MichelJuillard response that
It could as well as Julia can't produce complex residuals
added 10 commits
-
6e8a78e6...6fde1b05 - 8 commits from branch
Dynare:master
- 703f80b7 - StaticModel: remove transformation of complex residuals
- 486d04b9 - StaticModel: remove transformation of complex residuals for Julia as well
-
6e8a78e6...6fde1b05 - 8 commits from branch
added 6 commits
-
486d04b9...d95c2f2b - 4 commits from branch
Dynare:master
- 5313286d - StaticModel: remove transformation of complex residuals
- f08d02ea - StaticModel: remove transformation of complex residuals for Julia as well
-
486d04b9...d95c2f2b - 4 commits from branch
mentioned in commit bdb5cdac
Please register or sign in to reply