Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
M
mdbnomics
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • DBnomics
  • mdbnomics
  • Issues
  • #7

Closed
Open
Opened Mar 26, 2020 by Houtan Bastani@houtanb

fetch_series_by_api_link.m

  • document better in header (what goes in varargin)
  • line 21: if series_list is empty, set df={}; then return. Otherwise the rest of the code is indented as you have it now...
  • line 30: length(dataset_codes)
  • example in header doesn't work: fetch_series_by_api_link("https://api.db.nomics.world/v22/series?provider_code=AMECO&dataset_code=ZUTN")
  • this function is very slow. It took 10 seconds to run fetch_series_by_api_link("https://api.db.nomics.world/v22/series/BIS/long_pp?limit=1000&offset=0&q=&observations=1&align_periods=1&dimensions=%7B%7D") on my computer. It seems like the bulk of the time is spent in the loop starting on line 109. On first look, you don't need to go through this cell by cell, rather column by column, avoiding the inner loop. You should also be able to assign the first row in one line as ordered_columns_names will be a cell array of strings once #8 (closed) is done, removing the loop on lines 56-60. You may want to initialize df to NaN as well.... anyway, we'll review all of this once #8 (closed) is done.
Edited Mar 26, 2020 by Houtan Bastani
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dbnomics/mdbnomics#7