Improve the script for creating download links

— factorize the two scripts into a single one
— various safety and style improvements

.gitlab-ci.yml

@@ -16,9 +16,8 @@ build:
     GEM_HOME: "$CI_PROJECT_DIR/.gem"
   before_script:
     - gem install jekyll
-    - (cd _data && wget https://www.dynare.org/RePEc/cpm/dynare/wp.yml)
-    - ./setup-release.sh
-    - ./setup-snapshots.sh
+    - (cd _data && wget --no-verbose https://www.dynare.org/RePEc/cpm/dynare/wp.yml)
+    - ./setup-download-links.sh
     - bundle install
   script:
     - (cd assets/images/logo && make)

setup-download-links.sh

+#!/bin/bash
+
+set -e
+
+for branch in release snapshot
+do
+    mkdir -p "assets/$branch"
+    cd "assets/$branch"
+
+    wget --no-verbose "https://www.dynare.org/$branch/macosx.json"
+    wget --no-verbose "https://www.dynare.org/$branch/source.json"
+    wget --no-verbose "https://www.dynare.org/$branch/windows.json"
+    wget --no-verbose "https://www.dynare.org/$branch/windows-zip.json"
+
+    arr=("macosx" "source" "windows" "windows-zip")
+
+    for dir in "${arr[@]}"
+    do
+        mkdir -p "$dir"
+        mapfile -t filenames < <(jq .[].filename "$dir.json")
+        mapfile -t timestamps < <(jq .[].date "$dir.json")
+        n=$(jq length "$dir.json")
+        cd "$dir"
+        for ((i = 0; i < n; i++))
+        do
+            filename="${filenames[i]%\"}"
+            filename="${filename#\"}"
+            timestamp="${timestamps[i]%\"}"
+            timestamp="${timestamp#\"}"
+            echo "$filename $timestamp"
+            touch -amt "$timestamp" "$filename"
+        done
+        cd -
+    done
+    rm -- *.json
+    cd -
+done

setup-release.sh

-#!/bin/bash
-
-mkdir -p assets/release
-cd assets/release
-
-wget http://www.dynare.org/release/macosx.json
-wget http://www.dynare.org/release/source.json
-wget http://www.dynare.org/release/windows.json
-wget http://www.dynare.org/release/windows-zip.json
-
-declare -a arr=("macosx" "source" "windows" "windows-zip")
-
-for dir in "${arr[@]}"
-do
-    mkdir $dir
-    filenames=(`jq .[].filename $dir.json`)
-    timestamps=(`jq .[].date $dir.json`)
-    n=`jq length $dir.json`
-    n=`expr $n - 1`
-    cd $dir
-    for i in `seq 0 $n`;
-    do
-        filename="${filenames[i]%\"}"
-        filename="${filename#\"}"
-        timestamp="${timestamps[i]%\"}"
-        timestamp="${timestamp#\"}"
-        echo $filename $timestamp
-        touch -amt $timestamp $filename
-    done
-    cd ..
-done
-rm *.json
-cd ../..

setup-snapshots.sh

-#!/bin/bash
-
-mkdir -p assets/snapshot
-cd assets/snapshot
-
-wget http://www.dynare.org/snapshot/macosx.json
-wget http://www.dynare.org/snapshot/source.json
-wget http://www.dynare.org/snapshot/windows.json
-wget http://www.dynare.org/snapshot/windows-zip.json
-
-declare -a arr=("macosx" "source" "windows" "windows-zip")
-
-for dir in "${arr[@]}"
-do
-    mkdir $dir
-    filenames=(`jq .[].filename $dir.json`)
-    timestamps=(`jq .[].date $dir.json`)
-    n=`jq length $dir.json`
-    n=`expr $n - 1`
-    cd $dir
-    for i in `seq 0 $n`;
-    do
-        filename="${filenames[i]%\"}"
-        filename="${filename#\"}"
-        timestamp="${timestamps[i]%\"}"
-        timestamp="${timestamp#\"}"
-        echo $filename $timestamp
-        touch -amt $timestamp $filename
-    done
-    cd ..
-done
-rm *.json
-cd ../..