Skip to content
Snippets Groups Projects
Verified Commit cbfad751 authored by Sébastien Villemot's avatar Sébastien Villemot
Browse files

Remove some unnecessary temporary std::string allocation

Automatically detected by clang-tidy using
performance-inefficient-string-concatenation check.

Several of the detected cases are left unattended, because the syntax is more
elegant as it is, and they are not performance-critical.
parent b31de3d9
Branches
No related tags found
No related merge requests found
...@@ -1169,7 +1169,7 @@ ModelTree::fixNestedParenthesis(ostringstream& output, map<string, string>& tmp_ ...@@ -1169,7 +1169,7 @@ ModelTree::fixNestedParenthesis(ostringstream& output, map<string, string>& tmp_
if (auto it = tmp_paren_vars.find(val); it == tmp_paren_vars.end()) if (auto it = tmp_paren_vars.find(val); it == tmp_paren_vars.end())
{ {
varname = "paren32_tmp_var_" + to_string(i1++); varname = "paren32_tmp_var_" + to_string(i1++);
repstr = repstr + varname + " = " + val + ";\n"; repstr += varname + " = " + val + ";\n";
tmp_paren_vars[val] = varname; tmp_paren_vars[val] = varname;
} }
else else
...@@ -1182,7 +1182,7 @@ ModelTree::fixNestedParenthesis(ostringstream& output, map<string, string>& tmp_ ...@@ -1182,7 +1182,7 @@ ModelTree::fixNestedParenthesis(ostringstream& output, map<string, string>& tmp_
if (auto it = tmp_paren_vars.find(str1); it == tmp_paren_vars.end()) if (auto it = tmp_paren_vars.find(str1); it == tmp_paren_vars.end())
{ {
varname = "paren32_tmp_var_" + to_string(i1++); varname = "paren32_tmp_var_" + to_string(i1++);
repstr = repstr + varname + " = " + str1 + ";\n"; repstr += varname + " = " + str1 + ";\n";
} }
else else
varname = it->second; varname = it->second;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment