Skip to content
Snippets Groups Projects

posterior smoother subdraws

Closed Marco Ratto requested to merge rattoma/dynare:posterior_smoother into master
1 unresolved thread

force solving the model for smoother, by relaxing qz_criterium, when taking posterior subdraws (likelihood has been already evaluated without error for the same parameter vector).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Pfeifer
    • I see two ways out here:

      1. We indeed go for the solution outlined above:

      computing the smoother with reduced state space (as for likelihood) and retrieve ex-post the remaining static variables. I have no clue how involved this would be (also in terms of the timeframe)

      1. Adjust this PR to try to adjust qz_criterium (potentially iteratively in steps of factor 10), but only conditional on the value of info (I guess 3,4, and 5), regardless of whether this applies to the prior or posterior.
    • Author Developer

      option 1. would be ready for PR. while doing so, I also spotted the 2 bugs, which I fixed in !1847 (closed)

      option 2. I would apply it only for posterior (we do not know if likelihood is OK there: unless we check if likelihood is computable if info>0), I would not increase more than in two steps by factor 10.

    • Then I would prefer option 1. It seems less error prone and hackish.

    • Seeing the smoother_redux-implementation, I don't think it's feasible to use this as the default. In !1860 (merged) I instead fail gracefully.

    • Author Developer

      agree, thanks!

    • Please register or sign in to reply
  • requested review from @JohannesPfeifer

  • Johannes Pfeifer mentioned in merge request !1860 (merged)

    mentioned in merge request !1860 (merged)

  • Johannes Pfeifer resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading