Also disable RemoveSemicolon option by default, since the clang-format manual
states that these options can lead to incorrect formatting and thus their
result should be carefully reviewed.

– enable new options InsertNewlineAtEOF and RemoveSemicolon
– reformat the code accordingly

(manually cherry picked from commit 4ecb7fe5)

Since the lock was not assigned to a variable, it was a temporary value and
would thus be immediately released.

Problem detected through a warning produced by GCC 14.

(cherry picked from commit a13b2b57)

The method Evaluate::getCurrentBlockEndogenous() would always return an empty
vector, because of a weirdness in FBEGINBLOCK class (after deserialization, the
latter has “variables” member unset and the corresponding data is instead store
in “Block_Contain_”).

On the master branch, the problem has been solved differently (the weirdness in
the FBEGINBLOCK class has been removed).

Function Interpreter::check_for_controlled_exo_validity() would give incorrect
results because the sconstrained_extended_path structure was containing 1-based
variable indices (it is expecting 0-based ones).

(cherry picked from commit 9d3c3917)

They’re not implemented in bytecode.

Closes: #1884
(cherry picked from commit 8954a682)

Also minor improvements to solve_algo description.

(cherry picked from commit ffb57827)

Also ensure that guards are not reserved identifiers (i.e. starting with an
underscore).

Automatically detected by clang-tidy using performance-unnecessary-value-param
and performance-move-const-arg checks.

Automatically detected by clang-tidy with performance-noexcept-move-constructor
check.

Such calls may bypass virtual dispatch.

Automatically detected by clang-tidy with
clang-analyzer-optin.cplusplus.VirtualCall check.

Dynare++ is no longer distributed as a standalone binary.

Automatically detected by clang-tidy with modernize-use-auto check.

Automatically detected by clang-tidy with modernize-return-braced-init-list
check.

Automatically detected by clang-tidy with modernize-pass-by-value check.

Automatically detected by clang-tidy with modernize-use-default-member-init
check.

Automatically detected by clang-tidy with modernize-use-override check.

Automatically detected by clang-tidy using modernize-use-transparent-functors
check.

Automatically detected by clang-tidy using
clang-diagnostic-unused-but-set-variable, clang-analyzer-deadcode.DeadStores
and clang-diagnostic-unused-const-variable checks.

Automatically detected by clang-tidy using modernize-avoid-c-arrays check.

Automatically detected using clang-tidy with modernize-use-nodiscard check.

That header is needed from DynamicModelCaller.hh.

Issue detected by clang-tidy.

The test “solve_algo >= 6 || solve_algo <= 8” was always true.

Issue detected by clang-tidy using the
clang-diagnostic-tautological-overlap-compare check.

That class is a base class, so it must have a virtual destructor to avoid
memory leaks.

Issue detected by clang-tidy with
clang-diagnostic-delete-non-abstract-non-virtual-dtor check.

Detected by clang-tidy using clang-analyzer-cplusplus.Move check.

Automatically detected and fixed using clang-tidy with modernize-pass-by-value
check.

Automatically detected and fixed using clang-tidy with
modernize-return-braced-init-list check.

Automatically detected and fixed using clang-tidy with modernize-use-auto
check.

Automatically detected and fixed using clang-tidy with modernize-use-nodiscard
check.

Unfortunately it is not possible to enable it for all supported Octave
versions (which would have allowed us to remove the old codepath), because of
this bug: https://savannah.gnu.org/bugs/?64687

Ref. #1907

Compilation wargnings were pointing at: (i) some supposedly uninitialized variables (-Wmaybe-uninitialized); (ii) a pointer assignment (=) to a non-pointer target (-Wsurprising).

The latter is now much faster than the implementation in the bytecode
MEX (which this commit thus removes).