Close and delete generated file if cherry picking fails for any reason.

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing spaces)

Fix two bugs for block decomposed models

See merge request Dynare/dynare!1911

Occbin: remove redundant output

See merge request Dynare/dynare!1910

Also do earlier check for loglinear option

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing space)

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing space)

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

Closes Dynare/dynare#1808

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing whitespaces)

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing whitepaces)

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing spaces)

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

(@stepan removed trailing spaces)

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

Related to Dynare/dynare#7

Johannes Pfeifer authored 3 years ago and Stéphane Adjemian committed 3 years ago

- Use UTF8-encoding
- Remove useless options and packages
- Use doi where possible

Willi Mutschler authored 3 years ago and Stéphane Adjemian committed 3 years ago

lsqnonlin is an optimization algorithm that is specifically well suited for minimizing quadratic objectives, so I would like to have it as default. However, we fallback to csminwel if the optimization toolbox for Matlab or optim for Octave are not available.

Willi Mutschler authored 3 years ago and Stéphane Adjemian committed 3 years ago

Instead of checking everything in one mod file, this commit separates the checks into individual mod files that test:
- whether the translation from matched_moments works
- whether the duplicate moments are found
- whether GMM and SMM both work with different estimated_params blocks.
wip

Willi Mutschler authored 3 years ago and Stéphane Adjemian committed 3 years ago

//wip

Willi Mutschler authored 3 years ago and Stéphane Adjemian committed 3 years ago

As we have a working interface now, this commit improves the provisional handling of finding duplicate moments. Previously, indices for GMM were created, but this is not really needed. This commit cleans this up and similar to SMM makes use of the matched_moments block.

As a by-product of the previous provisonal handling higher-order moments for SMM where not correctly displayed as no labels were created. This is now fixed. The comparison of data moments and estimated model moments is also in the same ordering as the inputed orthogonality conditions in matched_moments.

Signed-off-by: Willi Mutschler <willi@mutschler.eu>